Update swagger generated API crates #590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #590 +/- ##
=======================================
Coverage ? 57.76%
=======================================
Files ? 168
Lines ? 9912
Branches ? 0
=======================================
Hits ? 5726
Misses ? 4186
Partials ? 0 ☔ View full report in Codecov by Sentry. |
|
No New Or Fixed Issues Found |
dani-garcia
force-pushed
the
ps/update-swagger
branch
from
f9b6360 to
9727d46
Compare
Hinton
reviewed
Feb 8, 2024
Hinton
approved these changes
Feb 8, 2024
dani-garcia
added a commit
that referenced
this pull request
Feb 8, 2024
## Type of change ``` - [ ] Bug fix - [ ] New feature development - [x] Tech debt (refactoring, code cleanup, dependency upgrades, etc) - [ ] Build/deploy pipeline (DevOps) - [ ] Other ``` ## Objective Extracted the autogenerated code from #590
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Objective
Update swagger generator to version 7.2.0, pull in the new templates and generate the new API crates.
I've also updated the build instructions to use .NET 8, as is required in the latest server code.
The version of the server code used to generate this is bitwarden/server@fc1d7c7
I've had to make some small modifications to the server code to get it working,
and I'll link the PR here shortly.bitwarden/server#3760To make this easier to review, I've split this into three commits:
f9b6360: New autogenerated swagger code, no manually edited files here.Moved to a separate PR (Update autogenerated swagger files #593)